Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#12 Correct LZW decoder for Tiff #1364

Merged
merged 2 commits into from
Sep 29, 2020
Merged

#12 Correct LZW decoder for Tiff #1364

merged 2 commits into from
Sep 29, 2020

Conversation

IldarKhayrutdinov
Copy link
Contributor

@IldarKhayrutdinov IldarKhayrutdinov commented Sep 28, 2020 •
edited
Loading

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

The LZW decoder was working completely wrong.
See: Decode_Rgba32_rgb_small_lzw.png

Now everything is ok, I added different test images:

@IldarKhayrutdinov IldarKhayrutdinov changed the title #12 LZW bug fix #12 LZW decoder bug fix Sep 29, 2020
JimBobSquarePants
JimBobSquarePants approved these changes Sep 29, 2020
View reviewed changes
Copy link
Member

@JimBobSquarePants JimBobSquarePants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I like that we don't depend on the IDisposable pattern anymore. I might update the gif one to do the same.

@JimBobSquarePants JimBobSquarePants merged commit a3ee6db into SixLabors:tiff-format Sep 29, 2020
@Dedme
Copy link

Dedme commented Oct 16, 2020

I see this passed a test only 16 days ago, but was wondering on timeline for this going into master?

@JimBobSquarePants
Copy link
Member

This was a fix for one small section of the Tiff codec. We won't move to master until the codec is feature complete.

@IldarKhayrutdinov IldarKhayrutdinov changed the title #12 LZW decoder bug fix #12 Correct LZW decoder for Tiff Dec 3, 2020
JimBobSquarePants added a commit that referenced this pull request Feb 17, 2021
@JimBobSquarePants
Merge pull request #1364 from IldarKhayrutdinov/tiff-format
8ccad40 
#12 LZW decoder bug fix
JimBobSquarePants added a commit that referenced this pull request Feb 17, 2021
@JimBobSquarePants
Merge pull request #1364 from IldarKhayrutdinov/tiff-format
32b5c11 
#12 LZW decoder bug fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JimBobSquarePants JimBobSquarePants JimBobSquarePants approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IldarKhayrutdinov @Dedme @JimBobSquarePants